enhancement: Added oportuniy set ImagePullSecret #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunames
requested review from
tobru and
Kidswiss
and removed request for
a team
eunames
force-pushed
the
enhancement/add_imagePullSecret
branch
from
8f469c9
to
ff85fd1
Compare
eunames
changed the title
Kidswiss
added
area:operator
area:chart
chart:k8up
enhancement
Kidswiss
requested changes
Mar 11, 2024
charts/k8up/Chart.yaml
Outdated
| @@ -6,7 +6,7 @@ keywords: | |||
| - backup | |||
| - operator | |||
| - restic | |||
| version: 4.4.3 | |||
| version: 4.4.4 | |||
There was a problem hiding this comment.
I would actually consider this a feature, can you bump it to 4.5.0 please?
Signed-off-by: Name Soname <bx-500@yandex.ru> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: eunames <eu505@hotmail.com>
There's a target that is commented-out in `envtest/integration.mk` that still shows up in the output of `make help`. This commit filters out lines that start with a comment (`#`) Signed-off-by: Manuel Hutter <manuel@hutter.io> Signed-off-by: eunames <eu505@hotmail.com>
¯\_(ツ)_/¯ Signed-off-by: Manuel Hutter <manuel@hutter.io> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Pooya Azarpour <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Pooya Azarpour <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
…tation). Ref: k8up-io#803 Signed-off-by: Pooya Azarpour <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
…reSingleFile` Signed-off-by: Pooya Azarpour <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Pooya Azarpour <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
…kind, the pod don't have OwnerReferences) Signed-off-by: Pooya Azarpour <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
[FIX] Fix helm chart of minio (The address of helm.min.io changed to charts.min.io) and values of chart has been change Signed-off-by: Pooya Azarpour <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Pooya Azarpour <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Benjamin Ritter <Benjamin.Ritter@protonmail.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Benjamin Ritter <Benjamin.Ritter@protonmail.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Tobias Brunner <tobias.brunner@vshn.ch> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Tobias Brunner <tobias.brunner@vshn.ch> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Tobias Brunner <tobias.brunner@vshn.ch> Signed-off-by: eunames <eu505@hotmail.com>
This test contains below sections: - Testing backup API for TLS and mTLS mode - Testing restore API in pvc for TLS and mTLS mode - Testing restore API in S3 for TLS and mTLS mode - Testing archive API in S3 for TLS and mTLS mode - Testin check API for TLS and mTLS mode Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
…NT_KEY_FILE env instead of filling TLS and mTls options in restore method Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
…is added Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
…unt, and options Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Also fixing bug in get lentgh of archive object in minio-mc Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
…s of Golang Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Pooya Azarpour <pooya_azarpour@yahoo.com>
…formatter) Signed-off-by: Pooya Azarpour <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Pooya Azarpour <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Pooya Azarpour <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Pooya Azarpour <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
These functions is created in utils: - AppendTLSOptionsArgs: for generate env for backend and restore specs - AttachTLSVolumes: for create volumes for pods AttachTLSVolumeMounts: for create volumeMount for backend and restore specs Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
… case and spend too much time Move restore and archive test case to two separated files Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: poyaz <pooya_azarpour@yahoo.com> Signed-off-by: eunames <eu505@hotmail.com>
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> Signed-off-by: eunames <eu505@hotmail.com>
eunames
force-pushed
the
enhancement/add_imagePullSecret
branch
from
b86d012
to
0e3b4e2
Compare
|
@eunames Could you rebase your branch so we can have a look at the change again and merge it if everything looks good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added oportuniy set ImagePullSecret param to manifest of job. It allows use a private registry for images when we use $BACKUP_IMAGE.
Fixes #567
Checklist
For Code changes
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog
area:operatorcharts/directory.For Helm Chart changes
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog
area:chartchart:k8upmake chart-docs