-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add podAnnotation to medusa operator and reaper operator #1449
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Please note that medusa-operator and reaper-operator are no longer actively developed. https://github.com/k8ssandra/k8ssandra-operator is where active development happens. With that said, I am happy to help you with this PR. Feel free to discuss on the K8ssandra as well :)
@@ -11,6 +11,10 @@ spec: | |||
template: | |||
metadata: | |||
labels: {{- include "k8ssandra-common.labels" . | indent 8 }} | |||
{{- with .Values.podAnnotations }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't .podAnnotations
be under annotations
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsanda Could you check again? I updated some commits based on your comments.
@@ -11,6 +11,10 @@ spec: | |||
template: | |||
metadata: | |||
labels: {{- include "k8ssandra-common.labels" . | indent 8 }} | |||
{{- with .Values.podAnnotations }} | |||
annotations: | |||
{{- toYaml . | nindent 8 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't the variable scope you want. It needs to be more narrow.
@@ -10,6 +10,10 @@ spec: | |||
template: | |||
metadata: | |||
labels: {{- include "k8ssandra-common.labels" . | indent 8 }} | |||
{{- with .Values.podAnnotations }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as comments for medusa-operator chart.
3c58e42
to
a5d095d
Compare
Thanks for the information. We definitely will migrate our k8ssandra to 2.x in the future. However, so far we are not going to do it recently. Please help me out with this PR. Thanks :)))) |
What this PR does:
Add
annotations
to thedeployment.yaml
for medusa-operator and reaper-operator, so that thepodAnnotations
can be applied to the generateddeployment.yaml
Which issue(s) this PR fixes:
Fixes #
Checklist