Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Google Vertex AI as provider to utilize gemini via GCP #984

Merged
merged 8 commits into from Mar 11, 2024

Conversation

mfahlandt
Copy link
Contributor

@mfahlandt mfahlandt commented Feb 25, 2024

📑 Description

Adds VertexAI of GCP as a possible provider - this was asked as a possible feature here: https://k8sgpt.slack.com/archives/C050SKW7SHF/p1708033891149459

Another reason for adding it - currently Gemini API is not supported in a lot of regions (e.g. any EU Country + Australia) but Vertex AI is available to be used via GCP (https://ai.google.dev/available_regions)

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required DocsPR
  • All the tests have passed

ℹ Additional Information

@mfahlandt mfahlandt changed the title Add Google Vertex AI as provider to utilize Gemini via GCP feat: Add Google Vertex AI as provider to utilize gemini via GCP Feb 25, 2024
@mfahlandt
Copy link
Contributor Author

/retest

@mfahlandt mfahlandt changed the title feat: Add Google Vertex AI as provider to utilize gemini via GCP feat: add Google Vertex AI as provider to utilize gemini via GCP Feb 25, 2024
Signed-off-by: Mario Fahlandt <mfahlandt@pixel-haufen.de>
@mfahlandt mfahlandt marked this pull request as ready for review February 25, 2024 23:15
@mfahlandt mfahlandt requested review from a team as code owners February 25, 2024 23:15
@arbreezy
Copy link
Member

arbreezy commented Mar 5, 2024

It lgtm but can't test it as I dont have vertex ai, it will be nice if you can share a screenshot of vertex integration while running k8sgpt analyze -e

Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good.
i just comment minor comments.

and does what if gemini API support other regions? then maybe we don't need to maintain this provider.

does it takes long time to gemini API supports other regions??

cmd/auth/add.go Outdated Show resolved Hide resolved
pkg/ai/googlevertexai.go Show resolved Hide resolved
@mfahlandt
Copy link
Contributor Author

It lgtm but can't test it as I dont have vertex ai, it will be nice if you can share a screenshot of vertex integration while running k8sgpt analyze -e

Shure:
image

@mfahlandt
Copy link
Contributor Author

and does what if gemini API support other regions? then maybe we don't need to maintain this provider.

does it takes long time to gemini API supports other regions??

We could potentially then remove this provider.
For now Vertex is the only option to use Gemini in GCP and this might still be the case after Gemini API expands, as the billing is different as it looks like.
In this Slack Thread the request was because the company does allow GCP but not Gemini Studio.
I would treat it the same way as Bedrock & Sagemaker are treated for AWS.
The main issue is also for Gemini API this is more of a Law topic, as Gemini API is basically not supported in any region with extensive GDPR laws - e.g. EU/GB/Australia - my bet as a european this will take some time.

Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall good!

and need to resolve DCO

Signed-off-by: Mario Fahlandt <mfahlandt@pixel-haufen.de>
@mfahlandt
Copy link
Contributor Author

overall good!

and need to resolve DCO

yeah the signing was missing, for whatever reason :(
Thanks for the review!

@AlexsJones AlexsJones enabled auto-merge (squash) March 11, 2024 07:33
@AlexsJones AlexsJones merged commit 55ac0b2 into k8sgpt-ai:main Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants