Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a typo in Azure provider auth config script #94

Merged
merged 1 commit into from Feb 29, 2024

Conversation

HaiyangDING
Copy link

@HaiyangDING HaiyangDING commented Feb 28, 2024

Closes #

πŸ“‘ Description

This PR fixes a typo in AzureOpenAI configuration script: a key field (add) is missing in k8sgpt auth command.

βœ… Checks

βœ… My pull request adheres to the code style of this project
βœ… My code requires changes to the documentation
βœ… I have updated the documentation as required

  • All the tests have passed
    • No. Only changed one line in doc, do we have to run a CI?

β„Ή Additional Information

Copy link

netlify bot commented Feb 28, 2024

βœ… Deploy Preview for meek-marigold-103c48 ready!

Name Link
πŸ”¨ Latest commit b316e7c
πŸ” Latest deploy log https://app.netlify.com/sites/meek-marigold-103c48/deploys/65def33fa6a21c0008eea81d
😎 Deploy Preview https://deploy-preview-94--meek-marigold-103c48.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Ubuntu <dingh@dinghvm.nmymwbntgfsu3hqr5dmy2zdhme.bx.internal.cloudapp.net>
@HaiyangDING
Copy link
Author

@AlexsJones

Hi Alex, I found a typo in Azure provider config script when trying k8sgpt. Please take a look at this PR.

Let me know if I need to do anything else to get the PR right.

Thanks!

@AlexsJones
Copy link
Member

Thank you for this!

@HaiyangDING
Copy link
Author

Merging is blocked since commit needs to be signed. I am trying to figure out how to unblock.

@AlexsJones AlexsJones merged commit c21beb3 into k8sgpt-ai:main Feb 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants