Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added prometheus integration guide #88

Merged
merged 2 commits into from Jan 17, 2024

Conversation

pintohutch
Copy link
Contributor

@pintohutch pintohutch commented Jan 12, 2024

This change includes activation instructions and explanations for the various analyzers of the Prometheus integration.

Closes k8sgpt-ai/k8sgpt#858

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Copy link

netlify bot commented Jan 12, 2024

βœ… Deploy Preview for meek-marigold-103c48 ready!

Name Link
πŸ”¨ Latest commit cabbf0b
πŸ” Latest deploy log https://app.netlify.com/sites/meek-marigold-103c48/deploys/65a6bac315b65f000961fff1
😎 Deploy Preview https://deploy-preview-88--meek-marigold-103c48.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This change includes activation instructions and explanations for the
various analyzers of the Prometheus integration.

Signed-off-by: Daniel Clark <danielclark@google.com>
@AlexsJones
Copy link
Member

Got time to take a look @AnaisUrlichs ?

@AnaisUrlichs
Copy link
Member

Hey, thanks, looking now :)

Copy link
Member

@AnaisUrlichs AnaisUrlichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments otherwise, it looks good, thank you

- Added a header about Prerequisites
- Made previous Prometheus installation note more clear

Signed-off-by: Daniel Clark <danielclark@google.com>
Copy link
Contributor Author

@pintohutch pintohutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. Addressed some comments

docs/reference/cli/filters.md Show resolved Hide resolved
docs/reference/cli/filters.md Show resolved Hide resolved
docs/reference/cli/filters.md Outdated Show resolved Hide resolved
docs/reference/cli/filters.md Show resolved Hide resolved
@AlexsJones AlexsJones merged commit 961486b into k8sgpt-ai:main Jan 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation: Add Prometheus integration docs
3 participants