operator [R] [CI] prometheus-exporter-operator (0.2.0 0.2.4 0.7.0)

[slopezz]

Thanks submitting your Operator. Please check below list before you create your Pull Request.

New Submissions

• Are you familiar with our contribution guidelines?
• Have you packaged and deployed your Operator for Operator Framework?
• Have you tested your Operator with all Custom Resource Definitions?
• Have you tested your Operator in all supported installation modes?
• Have you considered whether you want use semantic versioning order?
• Is your submission signed?
• Is operator icon set?

Updates to existing Operators

• Did you create a ci.yaml file according to the update instructions?
• Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
• Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
• Have you tested an update to your Operator when deployed via OLM?
• Is your submission signed?

Your submission should not

• Modify more than one operator
• Modify an Operator you don't own
• Rename an operator - please remove and add with a different name instead
• Modify any files outside the above mentioned folders
• Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

1. Description about the managed Application and where to find more information
2. Features and capabilities of your Operator and how to use it
3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

• Human readable name and 1-liner description about your Operator
• Valid category name¹
• One of the pre-defined capability levels²
• Links to the maintainer, source code and documentation
• Example templates for all Custom Resource Definitions intended to be used
• A quadratic logo

Remember that you can preview your CSV here.

--

¹ If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

² For more information see here

[github-actions]

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

[github-actions]

Dear @slopezz,
Some errors and/or warnings were found while doing the check of your operator (prometheus-exporter-operator/0.7.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type	Message
⚠️	Value : (prometheus-exporter-operator.v0.7.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.

[github-actions]

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

[github-actions]

Dear @slopezz,
Some errors and/or warnings were found while doing the check of your operator (prometheus-exporter-operator/0.7.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type	Message
⚠️	Value : (prometheus-exporter-operator.v0.7.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.

[slopezz]

The latest version of prometheus-exporter-operator published in k8s-operatorhub, version v0.2.4, is very outdated (there was v0.3.0, v0.4.0.. until latest v0.7.0), and this PR tries to update operator to latest available version, which was successfully merged in openshift-operatorhub redhat-openshift-ecosystem/community-operators-prod#3218 using the exact same yamls:

Outdated v0.2.4

• It was using originally package manifest format instead of bundle format. However it seems long time ago repo maintainers updated it to use bundle format 7e040f3
• It was using replaces-mode instead of semver-mode at ci.yaml
• Operator deployment was called prometheus-exporter-operator (because was created with an old operator-sdk version)

Current v0.7.0

• It uses correctly bundle format (actually since v0.3.0, which is missing in outdated k8s-operatorhub)
• It uses sem-ver at ci.yaml (actually since v0.3.0, which is missing in outdated k8s-operatorhub)
• Operator deployment is called prometheus-exporter-operator-controller-manager
  • This means that it is probable that an upgrade from v0.2.4 to latest v0.7.0 can fail, and it is expected and documented at
    https://github.com/3scale-ops/prometheus-exporter-operator/releases/tag/v0.3.0

OperaturHub CI

Surprisingly, despite all possible breaking changes between the 2 versions, the CI is only failing 1 test:

TASK [deploy_olm_operator_upstream_bundle : Wait for the operator prometheus-exporter-operator-controller-manager pod to start up] ***
fatal: [localhost]: FAILED! => changed=true 
  attempts: 90
  cmd: kubectl get pods -n test-operators| grep prometheus-exporter-operator-controller-manager | grep Running
  delta: '0:00:00.095732'
  end: '2023-09-18 15:41:22.672216'
  msg: non-zero return code
  rc: 1
  start: '2023-09-18 15:41:22.576484'
  stderr: ''
  stderr_lines: <omitted>
  stdout: ''
  stdout_lines: <omitted>
...ignoring

However it is a bit weird, since this v0.7.0 version, with the same exact yamls, have been successfully merged in openshift-operatorhub redhat-openshift-ecosystem/community-operators-prod#3218:

If for any reason there is no easy way of having old v0.2.0 and v0.2.4 coliving together with v0.7.0, I don't mind deleting older versions and keep just v0.7.0.

[github-actions]

Dear @slopezz,
Some errors and/or warnings were found while doing the check of your operator (prometheus-exporter-operator/0.7.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type	Message
⚠️	Value : (prometheus-exporter-operator.v0.7.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.

[github-actions]

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

[github-actions]

Dear @slopezz,
Some errors and/or warnings were found while doing the check of your operator (prometheus-exporter-operator/0.7.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type	Message
⚠️	Value : (prometheus-exporter-operator.v0.7.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.

[github-actions]

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

[github-actions]

Dear @slopezz,
Some errors and/or warnings were found while doing the check of your operator (prometheus-exporter-operator/0.7.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type	Message
⚠️	Value : (prometheus-exporter-operator.v0.7.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.

[slopezz]

I deleted old versions just in case that's the root problem, so only keeping new v0.7.0, which was successfully submitted to OCP-operatorHub

However the same CI test fails on the same place:

TASK [deploy_olm_operator_upstream_bundle : Wait for the operator prometheus-exporter-operator-controller-manager pod to start up] ***
fatal: [localhost]: FAILED! => changed=true 
  attempts: 90
  cmd: kubectl get pods -n test-operators| grep prometheus-exporter-operator-controller-manager | grep Running
  delta: '0:00:00.075524'
  end: '2023-09-20 09:03:23.017606'
  msg: non-zero return code
  rc: 1
  start: '2023-09-20 09:03:22.942082'
  stderr: ''
  stderr_lines: <omitted>
  stdout: ''
  stdout_lines: <omitted>
...ignoring

...

TASK [deploy_olm_operator_upstream_bundle : Report a brief installation summary] ***
ok: [localhost] => 
  prow_summary:
  - Operator is in packagemanifests                    [OK]
  - Operator started after subscribed to channel       [FAIL]
  - Operator was able to stay healthy 1 min            [FAIL]

So I force-pushed again older versions since the error is always the same.

I know 100% that operator works, since which it was successfully merged in openshift-operatorhub redhat-openshift-ecosystem/community-operators-prod#3218 using the exact same yamls, and operator upgrade happened seamlessly since OperatorHub version was updated.

So, which is the best way to proceed with CI failing test?

[github-actions]

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

[github-actions]

Dear @slopezz,
Some errors and/or warnings were found while doing the check of your operator (prometheus-exporter-operator/0.7.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type	Message
⚠️	Value : (prometheus-exporter-operator.v0.7.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.

[github-actions]

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

[github-actions]

Dear @slopezz,
There are some operators version that are using deprecated api and kubernetes max versions (operatorhub.io/ui-metadata-max-k8s-version) is NOT set correctly under annotation field in CSV file.

Affected versions : prometheus-exporter-operator:v0.2.0,prometheus-exporter-operator:v0.2.4

More info in 'Kubernetes max version in CSV' section here.

[github-actions]

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

[github-actions]

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

[github-actions]

Dear @slopezz,
Some errors and/or warnings were found while doing the check of your operator (prometheus-exporter-operator/0.7.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type	Message
⚠️	Value : (prometheus-exporter-operator.v0.7.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.

[github-actions]

Dear @slopezz,
Some errors and/or warnings were found while doing the check of your operator (prometheus-exporter-operator/0.7.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type	Message
⚠️	Value : (prometheus-exporter-operator.v0.7.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.