Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator postgres-operator (1.5.0) #3184

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lodotek
Copy link

@lodotek lodotek commented Sep 7, 2023

Thanks submitting your Operator. Please check below list before you create your Pull Request.

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Dear @lodotek,
Some errors and/or warnings were found while doing the check of your operator (postgres-operator/1.5.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
🐛 Field spec.preserveUnknownFields, Value 0xc000a1bb68: spec.preserveUnknownFields: Invalid value: true: cannot set to true, set x-kubernetes-preserve-unknown-fields to true in spec.versions[*].schema instead
🐛 Field spec.preserveUnknownFields, Value 0xc0003d68c2: spec.preserveUnknownFields: Invalid value: true: cannot set to true, set x-kubernetes-preserve-unknown-fields to true in spec.versions[*].schema instead
⚠️ Value postgres-operator.v1.5.0: this bundle is using APIs which were deprecated and removed in v1.22. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-22. Migrate the API(s) for CRD: (["operatorconfigurations.acid.zalan.do" "postgresqls.acid.zalan.do"])
⚠️ Value postgres-operator.v1.5.0: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for cronjobs: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[13]"]),poddisruptionbudgets: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[12]"]),
⚠️ Value postgres-operator.v1.5.0: CSV contains permissions to create CRD. An Operator shouldn't deploy or manage other operators (such patterns are known as meta or super operators or include CRDs in its Operands). It's the Operator Lifecycle Manager's job to manage the deployment and lifecycle of operators. Please, review the design of your solution and if you should not be using Dependency Resolution from OLM instead. More info: https://sdk.operatorframework.io/docs/best-practices/common-recommendation/

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Dear @lodotek,
Some errors and/or warnings were found while doing the check of your operator (postgres-operator/1.5.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
🐛 Field spec.preserveUnknownFields, Value 0xc000626389: spec.preserveUnknownFields: Invalid value: true: cannot set to true, set x-kubernetes-preserve-unknown-fields to true in spec.versions[*].schema instead
⚠️ Value postgres-operator.v1.5.0: this bundle is using APIs which were deprecated and removed in v1.22. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-22. Migrate the API(s) for CRD: (["operatorconfigurations.acid.zalan.do" "postgresqls.acid.zalan.do"])
⚠️ Value postgres-operator.v1.5.0: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for cronjobs: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[13]"]),poddisruptionbudgets: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[12]"]),
⚠️ Value postgres-operator.v1.5.0: CSV contains permissions to create CRD. An Operator shouldn't deploy or manage other operators (such patterns are known as meta or super operators or include CRDs in its Operands). It's the Operator Lifecycle Manager's job to manage the deployment and lifecycle of operators. Please, review the design of your solution and if you should not be using Dependency Resolution from OLM instead. More info: https://sdk.operatorframework.io/docs/best-practices/common-recommendation/

@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation
Copy link
Collaborator

/merge possible

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

DCO is missing. Please signoff your commits !!!

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

DCO is missing. Please signoff your commits !!!

@mporrato
Copy link
Collaborator

@lodotek you need to sign off your commits before this pr can be accepted. See https://wiki.linuxfoundation.org/dco .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants