Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.30] Drop check for legacy traefik v1 chart #9593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brandond
Copy link
Contributor

Proposed Changes

Drop check for legacy traefik v1 chart

We have been bundling traefik v2 for three years, its time to drop the legacy chart check

Types of Changes

tech debt

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

K3s no longer automatically skips deploying traefik v2 if traefik v1 is present. All clusters should have been upgraded to v2 at some point over the last three years.

Further Comments

We have been bundling traefik v2 for three years, its time to drop the legacy chart check

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner February 28, 2024 21:49
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.88%. Comparing base (86f1021) to head (ae62605).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9593      +/-   ##
==========================================
- Coverage   49.44%   42.88%   -6.56%     
==========================================
  Files         151      154       +3     
  Lines       13471    13509      +38     
==========================================
- Hits         6661     5794     -867     
- Misses       5467     6547    +1080     
+ Partials     1343     1168     -175     
Flag Coverage Δ
e2etests ?
inttests 39.45% <ø> (+0.04%) ⬆️
unittests 15.96% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond
Copy link
Contributor Author

brandond commented Mar 1, 2024

moving to WIP until v1.30

@brandond brandond marked this pull request as draft March 1, 2024 00:16
@brandond brandond changed the title Drop check for legacy traefik v1 chart [release-v1.30] Drop check for legacy traefik v1 chart Mar 1, 2024
@brandond brandond marked this pull request as ready for review March 27, 2024 22:15
@brandond
Copy link
Contributor Author

brandond commented Mar 27, 2024

Ready for review, but DO NOT MERGE until after we branch release-1.29 from master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants