Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): update github action to call npm publish, add npmrc following github and npm docs #539

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwu910
Copy link
Owner

@jwu910 jwu910 commented Jul 13, 2023

Fixes #536

Description

Update the github action for publish cycle. using the .npmrc file to check for env vars during the publish script.

https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages#publishing-packages-to-the-npm-registry

According to docs, this should be good. Not a high priority, so this can go out with future releases after merged.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have read the CONTRIBUTING document.
  • My commits follow the commitizen commit convention
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jwu910 jwu910 requested a review from kienD as a code owner July 13, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automation - GH action setup for npm registry publishing
1 participant