Rename classes utility function to joinClasses in order to reduce naming confusion
#859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes include: - Add `joinClasses` as a drop-in replacement for the `classes` function - Deprecate `classes` function - Migrate existing code towards the new `joinClasses` function
haukesomm
changed the title
classes utility function to joinClassNames in order to reduce naming confusion
Lysander
requested changes
Apr 19, 2024
haukesomm
changed the title
classes utility function to joinClassNames in order to reduce naming confusionclasses utility function to joinClasses in order to reduce naming confusion
Lysander
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
joinClassesfunction to replace the currentclassesfunction in order to minimize naming confusion.The
classesfunction gets deprecated.Motivation
The current name was meant to be short, but as it seems quite often it competes with parameters having the same name, which are passed in from higher call sites. This might look confusing:
Migration
Use the added
joinClassesfunction over the now deprecatedclassesfunction. This can be done automatically via IntelliJ.Ideally, optimize your imports after replacing the respective calls.
Closes #828