This PR fixes some Flow-based focus-trap issue #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haukesomm
previously approved these changes
Mar 11, 2024
Lysander
force-pushed
the
chausknecht/fix-focustrap
branch
from
b4a7c37
to
d1721cd
Compare
When using the `trapFocusWhenever` in some rare situations, the focus-trap would remain alive after closing the trap-container. This bug is now closed. This was reproducible inside the `PopOver`-component (in the demo!): After closing the popover one could no more *tab* away from the button.
Lysander
force-pushed
the
chausknecht/fix-focustrap
branch
from
98de371
to
52276e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
trapFocusWheneverin some rare situations, the focus-trap would remain alive after closing the trap-container. This bug is now closed.This was reproducible inside the
PopOver-component (in the demo!): After closing the popover one could no more tab away from the button.