Merge pull request #784 from jgardo/twitter

Fix full twitter account url
jvm-bloggers · Feb 8, 2024 · 4aeefb8 · 4aeefb8
2 parents 461cc1a + 91c8a61
commit 4aeefb8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/main/java/com/jvm_bloggers/core/utils/LinkUtils.java b/src/main/java/com/jvm_bloggers/core/utils/LinkUtils.java
@@ -8,7 +8,12 @@ public class LinkUtils {
   private static final String TWITTER_HOME_URL = "https://twitter.com/";
 
   public static String getFullTwitterAccountUrl(String twitterHandle) {
-    return TWITTER_HOME_URL + twitterHandle;
+    if (twitterHandle == null) {
+      return TWITTER_HOME_URL;
+    }
+    if (twitterHandle.startsWith("@")) {
+      return TWITTER_HOME_URL + twitterHandle.substring(1);
+    }
+    return TWITTER_HOME_URL;
   }
-
 }
diff --git a/src/test/groovy/com/jvm_bloggers/utils/LinksSpec.groovy b/src/test/groovy/com/jvm_bloggers/utils/LinksSpec.groovy
@@ -11,8 +11,8 @@ class LinksSpec extends Specification {
     LinkUtils.getFullTwitterAccountUrl(twitterHandle) == fullUrl
     where:
     twitterHandle  | fullUrl
-    "@tnurkiewicz" | "https://twitter.com/@tnurkiewicz"
-    "@jkubrynski"  | "https://twitter.com/@jkubrynski"
+    "@tnurkiewicz" | "https://twitter.com/tnurkiewicz"
+    "@jkubrynski"  | "https://twitter.com/jkubrynski"
   }
 
 }