Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding venv check for VIRTUAL_ENV_PROMPT and assuring an empty 'prompt… #391

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philion
Copy link

@philion philion commented Dec 13, 2023

…' field doens't erase a valid venv.

Specific issues:

  1. No check for VIRTUAL_ENV_PROMPT.
  2. Logic error looking for "prompt" after successfully loading "pyvenv.cfg", where that config file doesn't have that key defined. (Side note: Key() will create a new key with an empty value, according to the source.)

I have patched and tested "on my own machine".

@philion philion changed the title Adding venv check for VIRTUAL_ENV_PROPT and assuring an empty 'prompt… Adding venv check for VIRTUAL_ENV_PROMPT and assuring an empty 'prompt… Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant