Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change code block style #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change code block style #54

wants to merge 1 commit into from

Conversation

justinmeiners
Copy link
Owner

@justinmeiners justinmeiners commented Jan 2, 2022

@aharrison24 any opinions?

@aharrison24
Copy link
Contributor

I do like the indenting. My initial reaction to the background change is that things look a bit 'stark' now. Though I admit am conditioned by the way that GitHub and Slack do things -- I'm used to some sort of box denoting a code block.

Ultimately I don't feel particularly strongly, but I'd probably come down on the side of having more than just a font and indent change signifying that something is a piece of code. I'm not sure what your underlying reason for the change is, so it's a bit hard to suggest good alternatives.

The existing grey blocks are certainly a bit ugly. Would it help to prettify them a bit? Both GitHub and Slack have nice rounded corners on the code blocks. Slack uses just a thin grey border and leaves the background colour untouched. Could something like that work?

Screen Shot 2022-01-04 at 20 59 25

@justinmeiners
Copy link
Owner Author

Thanks for the feedback. You and @rpendleton think alike.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline code should have monospaced font, but not background color.
2 participants