Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-webc): DSW-1962 add script to automate exporting components #1426

Merged
merged 37 commits into from May 14, 2024

Conversation

jamieomaguire
Copy link
Contributor

@jamieomaguire jamieomaguire commented May 1, 2024

Describe your changes (can list changeset entries if preferable)


"@justeattakeaway/pie-webc": minor

[Added] - An automation script named add-components which will add all pie components into pie-webc
[Added] - Supporting unit tests


"@justeattakeaway/generator-pie-component": minor

[Changed] - Invoke the new add-components command after generating new components to ensure they are correctly added to pie-webc
[Changed] - Improve logging and message formatting

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: 02e4ab9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@justeattakeaway/pie-webc Minor
@justeattakeaway/generator-pie-component Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jamieomaguire
Copy link
Contributor Author

/test-aperture

github-actions[bot]

This comment was marked as outdated.

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

The build failed, please see the logs or take a look at the Workflow Tooling wiki page to make sure your PR meets the requirements.

@jamieomaguire
Copy link
Contributor Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@jamieomaguire Your snapshot has been published to npm!

Test the snapshot by updating your package.json with the newly-published version:

yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20240501101952

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1426 May 1, 2024 10:21 Inactive
@jamieomaguire
Copy link
Contributor Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@jamieomaguire Your snapshot has been published to npm!

Test the snapshot by updating your package.json with the newly-published version:

yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20240501105350

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1426 May 1, 2024 14:20 Inactive
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1426 May 1, 2024 14:32 Inactive
@jamieomaguire jamieomaguire changed the title test without exports feat(pie-webc): DSW-1962 add script to automate exporting components May 1, 2024
@github-actions github-actions bot dismissed their stale review May 1, 2024 16:02

[Lint PR Title] ✅ All good!

@jamieomaguire
Copy link
Contributor Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1426 May 10, 2024 15:40 Inactive
@xander-marjoram xander-marjoram marked this pull request as ready for review May 10, 2024 15:59
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1426 May 10, 2024 16:07 Inactive
@xander-marjoram xander-marjoram added please review and removed work-in-progress This pull request is still a work in progress and may not be ready for review labels May 13, 2024
@xander-marjoram
Copy link
Contributor

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@xander-marjoram Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20240513075515 --mode=update-lockfile
yarn up @justeattakeaway/generator-pie-component@0.0.0-snapshot-release-20240513075515 --mode=update-lockfile

Then finally:

yarn install

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1426 May 13, 2024 15:51 Inactive
dandel10n
dandel10n previously approved these changes May 14, 2024
Copy link
Contributor

@dandel10n dandel10n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

@fernandofranca fernandofranca self-assigned this May 14, 2024
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1426 May 14, 2024 07:01 Inactive
fernandofranca
fernandofranca previously approved these changes May 14, 2024
Copy link
Contributor

@fernandofranca fernandofranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 Good automation stuff!!!

@xander-marjoram xander-marjoram merged commit 6451adf into main May 14, 2024
33 checks passed
@xander-marjoram xander-marjoram deleted the dsw-1962-webc-package branch May 14, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants