-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dsw-1962-webc-package integration #122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pie-design-system-bot
force-pushed
the
dsw-1962-webc-package
branch
from
May 1, 2024 16:05
a010e0c
to
b5329c5
Compare
pie-design-system-bot
force-pushed
the
dsw-1962-webc-package
branch
from
May 2, 2024 09:34
b5329c5
to
016c5d2
Compare
pie-design-system-bot
force-pushed
the
dsw-1962-webc-package
branch
from
May 2, 2024 09:38
016c5d2
to
14eb265
Compare
pie-design-system-bot
force-pushed
the
dsw-1962-webc-package
branch
from
May 13, 2024 07:56
23355a2
to
06cc8e2
Compare
xander-marjoram
force-pushed
the
dsw-1962-webc-package
branch
from
May 13, 2024 15:02
3d44d17
to
95d07b0
Compare
"@justeattakeaway/pie-card": "0.19.3", | ||
"@justeattakeaway/pie-chip": "0.6.1", | ||
"@justeattakeaway/pie-cookie-banner": "0.19.5", | ||
"@justeattakeaway/pie-cookie-banner": "0.19.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cookie banner dependency is still needed for now while we work out an approach with additional exports like the locales
fernandofranca
approved these changes
May 16, 2024
jamieomaguire
approved these changes
May 17, 2024
JoshuaNg2332
pushed a commit
that referenced
this pull request
May 17, 2024
* feat: dsw-1962-webc-package * pie-webc updates * Fix locale import * Use latest versions --------- Co-authored-by: Xander Marjoram <xander.marjoram@justeattakeaway.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been automatically generated as part of the test-aperture workflow from the Pie monorepo