Support SNS batch publishing #1335
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
added
enhancement
dependencies
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
samples/src/JustSaying.Sample.Restaurant.OrderingApi/Program.cs
Dismissed
Show dismissed
Hide dismissed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1335 +/- ##
==========================================
- Coverage 79.43% 78.68% -0.75%
==========================================
Files 138 140 +2
Lines 3234 3557 +323
Branches 448 501 +53
==========================================
+ Hits 2569 2799 +230
- Misses 434 511 +77
- Partials 231 247 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martincostello
commented
Feb 1, 2024
Comment on lines
+3
to
+5
| <PackageVersion Include="AWSSDK.SimpleNotificationService" Version="3.7.300" /> | ||
| <PackageVersion Include="AWSSDK.SQS" Version="3.7.300" /> |
There was a problem hiding this comment.
These are the minimum versions that support .NET 8 and AoT, so I think they're worth raising the baseline to as part of getting the batch publishing support.
martincostello
commented
Feb 1, 2024
| @@ -106,10 +106,12 @@ public Uri GetQueueUriByConvention<T>() | |||
| /// <returns>The <see cref="Uri"/> for this queue.</returns> | |||
| public Uri GetQueueUri(string queueName) | |||
| { | |||
| #pragma warning disable CS0618 // Type or member is obsolete | |||
| var hostname = _regionEndpoint.GetEndpointForService("sqs").Hostname; | |||
There was a problem hiding this comment.
This is obsolete, but using the new way is difficult to do for libraries without breaking compatibility or making things harder for consumers, so keeping using the old way.
martincostello
commented
Feb 1, 2024
There was a problem hiding this comment.
This was internal and just syntactic sugar, so I just removed it.
martincostello
commented
Feb 1, 2024
martincostello
force-pushed
the
support-batch-publishing
branch
from
1cc99f5
to
40d62da
Compare
martincostello
force-pushed
the
support-batch-publishing
branch
from
3dad5d1
to
51797df
Compare
Add support for batch publishing messages to SNS. Supersedes justeattakeaway#1098. Co-Authored-By: Rafael Lillo <7280959+lillo42@users.noreply.github.com>
- Remove some new methods to reduce new public API surface. - Add missing XML documentation. - Some minor code style fix-ups.
Apply outstanding review comments from justeattakeaway#1098.
Add more coverage for batch publishing.
Ensure that messages with dynamic topics are not all sent to the topic associated with the first message in a batch.
Condense the syntax.
Manual editing meant a missed comma.
Refactor things to make the public API analyser happy.
Add new unshipped members to baselines.
Use the explicit token option, rather than setting an environment variable.
Add new batch publishing APIs.
martincostello
force-pushed
the
support-batch-publishing
branch
from
51797df
to
5aa9601
Compare
Bump version to 7.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for batch publishing messages to SNS.
Supersedes #1098.
TODO
Review original feedback from GH-1095 Add support to batch operation #1098 and address.Check test coverage.Rebase on Add public API analyzer #1330 and add updated baselines.Update version to 7.2.0.