New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Devil #353
base: master
Are you sure you want to change the base?
Conversation
73d31db
to
6abe544
Compare
It would be nice to abstract this logic on the which-key side, so that any package can use it and which-key doesn't have to know about these packages |
I just tried the PR, and it LGTM. |
Ok I have found a bug, typing |
Hi @wesnel, @AkibAzmain :) What do we need to merge this? @AkibAzmain you mentioned that you found an error, what was it? |
What is Devil? > Devil mode trades your comma key in exchange for a modifier-free editing experience in Emacs. The above description comes from their README at: https://github.com/susam/devil Unfortunately, Devil is not currently supported by which-key. For example, when I type `, x`, the which-key popup for `C-x` does not appear. Instead, I merely see the following text in the echo area: ``` Devil: C-x ``` With this patch, I have mimicked the existing god-mode logic in which-key to intercept the current Devil prompt and spawn a which-key popup. This feature was requested by susam/devil#3: - susam/devil#3
6abe544
to
6079a3f
Compare
hi @AkibAzmain, i believe i have fixed your error. typing
i have fixed this by first performing a check on the current devil command string with i have also rebased to fix conflicts with the master branch. thanks all! |
Would love to see this merged! |
Hi, thanks for the contribution. I'm currently working on getting which-key merged into core emacs. In the process, I am disentangling the third-party support code from which-key in a way that will allow for third-party support without putting custom code in the which-key file. See what I did recently with god-mode so you can update this PR. It may no longer be necessary at all. To be clear the goal is to allow for third-party support without modifying the which-key code at all. This should be possible now, but if not I can make further changes. |
What is Devil?
The above description comes from their README at:
https://github.com/susam/devil
Unfortunately, Devil is not currently supported by which-key. For example, when I type
, x
, the which-key popup forC-x
does not appear. Instead, I merely see the following text in the echo area:With this patch, I have mimicked the existing god-mode logic in which-key to intercept the current Devil prompt and spawn a which-key popup.
This feature was requested by susam/devil#3: