Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not found error when running on windows #604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix not found error when running on windows #604

wants to merge 1 commit into from

Conversation

saadshahd
Copy link

process.env.path will always be true which will make the flag isElectronWebpack always false

@saadshahd
Fix not found error when running on windows
c78a21b 
`process.env.path` will always be `true` which will make the flag `isElectronWebpack` always `false`
@saadshahd
Copy link
Author

actually, it didn't fix the issue, I had to install Microsoft visual studio 2015 redistributable on all the machines that use my electron app

@justadudewhohacks
Copy link
Owner

process.env.path will always be true which will make the flag isElectronWebpack always false

I think we need a better solution to detect, whether the module is bundled with webpack then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saadshahd @justadudewhohacks