Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: protect search-data.json file from front matter default for layout #1468

Merged
merged 3 commits into from May 16, 2024
Merged

Fix: protect search-data.json file from front matter default for layout #1468

merged 3 commits into from May 16, 2024

Conversation

mattxwang
Copy link
Member

Fixes #1466. Prior art: #1447. Otherwise self-explanatory.

To test:

  1. First, clone template repository. Observe that search works.
  2. Next, add a default layout to all files
defaults:
  - scope:
      path: ""
    values:
      layout: "default"
  1. Observe that search no longer works.
  2. Apply this patch
  3. Observe that search works again!

pdmosses
pdmosses approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@pdmosses pdmosses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested okay. LGTM.

@mattxwang
Merge branch 'main' into protect-search-json
ef07b3f
@mattxwang
Add CHANGELOG entry
758c4db 
Later: need to fix Kevin's PR link, which is not expanded
@mattxwang mattxwang merged commit 2dd535c into main May 16, 2024
25 checks passed
@mattxwang mattxwang deleted the protect-search-json branch May 16, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdmosses pdmosses pdmosses approved these changes

Assignees

@pdmosses pdmosses

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mattxwang @pdmosses