Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom scheme combinations #1232

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add custom scheme combinations #1232

wants to merge 2 commits into from

Conversation

mattxwang
Copy link
Member

Right now, this PR is just a sketch of the feature described in #483. It does work!

To test:

  • first, run site as-is in the branch; observe that there are no errors (backwards-compatible)
  • add a custom scheme
    • create a custom_schemes folder
    • place a file in it (ex boop.scss)
    • add an overriding style (ex * { color: purple !important }
    • in _config.yml, define custom_schemes: ["boop"]
    • reload jekyll serve
    • observe that the site is now purple :)
  • add multiple schemes
    • rinse and repeat from above!

Things to still resolve:

  • where in the import order should this go? went with the original suggestion in the issue
  • documentation (if we like this implementation, I'll write some up)
  • in the short term, do we want to restructure any of our scheme/theme code to use this new key? likely not, right?

Closes #483.

@mattxwang mattxwang requested a review from pdmosses April 20, 2023 06:15
@mattxwang mattxwang marked this pull request as draft April 26, 2023 08:58
@mattxwang
Copy link
Member Author

@Ninja-mann07 it seems like you may have posted a patch by accident?

@just-the-docs just-the-docs deleted a comment from Ninja-mann07 Jun 19, 2023
@just-the-docs just-the-docs deleted a comment from Ninja-mann07 Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom scheme combination
1 participant