-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IMarkdownParser
interface and markedparser
extension.
#7291
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
02e1614
to
04c3a7c
Compare
@AlbertHilb would you be interested in rebooting this feature? It makes lots of sense to me and could help as you mention hooking another markdown renderer and it will avoid loading embedding codemirror in smaller extension derived application like gator. cc @agoose77 as author of |
@fcollonval I don't think this PR would simplify much for The reason JupyterLab has an Some useful changes as I see them:
|
Thanks for the quick answer @agoose77 I agree with you that it sounds more generic if those two where in their own packages. This will help simpler remix application to pick only what they want. |
This is the implementation of the idea I expressed in #5770.
The Markdown world is definitely moving towards CommonMark: GitHub, Discourse, GitLab have migrated to the new standard (with extensions); VSCode uses CommonMark (via markdown-it); even marked - the renderer used in Jupyterlab - is slowly but steadily embracing it.
Sooner or later also Jupyterlab will have to adopt CommonMark.
At that point the choice of the Markdown renderer will be based on the the parsing speed, on its capacity to be extended or on the ability to create sourcemaps, rather than on the output it produces (since different compliant renderers should virtually produce the same output).
The
IMarkdownParser
inteface, I think, will make easier to write Jupyterlab Markdown renderers based on different parsers, so that users will able to choose the one they prefer as already happens for the LaTeX renderers.Cheers