New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.6.x] Fix M1 install, declare node-gyp@^9.0.0
#15395
Conversation
Thanks for making a pull request to jupyterlab! |
@krassowski Thanks for adding me to the @jupyterlab org! I've added the labels. Will get the |
Thanks! Yes, |
@fcollonval Thanks for your input! Yes, I agree with this, although I maintain that there is a small risk involved. I'll update the PR shortly. BTW, I filed an issue on |
Updated the PR according to @fcollonval's feedback. CI is mostly passing, with a successful cc @krassowski |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dlqqq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dlqqq!
References
Fixes #15394.
Code changes
node-gyp@^9.0.0
indevDependencies
.yarn yarn-deduplicate
.User-facing changes
None known.
Backwards-incompatible changes
None known. This should be a safe change because
node-gyp
is used infrequently for most users, as they typically use x86_64, which should always have prebuilds.