Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to hatch #217

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ktaletsk
Copy link
Collaborator

Migrate installation from jupyter_packaging to hatch following the docs here: https://hatch-jupyter-builder.readthedocs.io/en/latest/source/how_to_guides/migrating_javascript_projects.html

@ktaletsk ktaletsk requested a review from fcollonval May 31, 2023 15:36
@fcollonval
Copy link
Member

@ktaletsk I would advice going a step further and migrate to the new extension template. It will allow to update the machinery through the template to ease maintenance. If you want I can help with that.

]
dependencies = [
"jupyter_server>=2,<3",
"jupyterlab>=4,<5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would drop the dependency on JupyterLab itself (except if you call a specific endpoint). This will allow to install this extension in Notebook v7 without installing JupyterLab as I guess this extension does not depend directly on the JupyterLab layout.

Suggested change
"jupyterlab>=4,<5",

"jupyterlab_latex/labextension/**",
"package-lock.json",
"yarn.lock"
[tool.tbump]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you switch to the new extension template, this will switch to using hatch directly aligning NPM and Python package version using: https://github.com/agoose77/hatch-nodejs-version

[tool.hatch.build.targets.wheel.shared-data]
"jupyterlab_latex/labextension/static" = "share/jupyter/labextensions/@jupyterlab/latex/static"
"install.json" = "share/jupyter/labextensions/@jupyterlab/latex/install.json"
"jupyterlab_latex/labextension/build_log.json" = "share/jupyter/labextensions/@jupyterlab/latex/build_log.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not check for this log file.

Suggested change
"jupyterlab_latex/labextension/build_log.json" = "share/jupyter/labextensions/@jupyterlab/latex/build_log.json"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants