Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Jupyterlab 4 and Lumino 2 #211

Merged
merged 13 commits into from
May 24, 2023
Merged

Conversation

RRosio
Copy link
Contributor

@RRosio RRosio commented Mar 24, 2023

This PR addresses #210, providing updates to Jupyterlab 4 and Lumino 2.

  • Fix Build (Current build check in CI is failing since status is not ok: @jupyterlab/latex v3.1.0 enabled X (python, jupyterlab-latex))

@welcome
Copy link

welcome bot commented Mar 24, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@ktaletsk
Copy link
Collaborator

ktaletsk commented May 21, 2023

Thanks for updating the extension, @RRosio!

I bumped some versions, applied minor changes and updated docs. I am now able to run the extension in Lab 4.0 locally and in Binder.

Binder

image

Please, let me know if you would like to to add any more changes. Otherwise, please mark this PR as Ready for review, so that we can merge it and make a 4.0 release of jupyterlab-latex!

@ktaletsk ktaletsk self-assigned this May 21, 2023
@RRosio
Copy link
Contributor Author

RRosio commented May 24, 2023

Thank you @ktaletsk! I tried it out as well and everything works great!

@RRosio RRosio marked this pull request as ready for review May 24, 2023 16:21
@ktaletsk ktaletsk merged commit 4f8d5b3 into jupyterlab:master May 24, 2023
1 check passed
@ktaletsk ktaletsk linked an issue May 25, 2023 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyterlab-latex update for Jupyterlab 4 and Lumino 2
2 participants