try out jupyterhub 1.2.0b1 #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
installing jupyterhub and requirements.txt on the same line doesn't work for upgrades due to the conflict of jupyterhub being mentioned twice. Perhaps better would be to exclude jupyterhub itself from requirements.txt? Doesn't seem to be supported without post-processing
|
Thanks @minrk for making a note about the duplicate version specification, I'm not sure either, but I really love your tooling with requirements.in being built in a dockerfile to requirements.txt! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and bumps dependencies in hub image
I had to tweak things a bit since our freezing code didn't play nice with the fact that the jupyterhub version is specified both inside requirements.txt and as a separate arg, which results in a conflict when the two versions don't match. I'm not sure what exactly is the best way to deal with that. Perhaps put jupyterhub version in requirements.in instead?
several were removed due to googleapis/google-auth-library-python#619 making aiohttp an optional dependency of google-auth. I think this is fine and shouldn't affect us, since this is a transitive dependency and we don't directly use google-auth + aiohttp. Presumably tests will reveal if we should add
google-auth[aiohttp]as a dependency...