Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Security team #721

Merged
merged 2 commits into from May 15, 2024
Merged

add Security team #721

merged 2 commits into from May 15, 2024

Conversation

minrk
Copy link
Member

@minrk minrk commented May 11, 2024

document security role and add @rpwagner, @dlqqq. @rpwagner can you confirm both of these memberships, and can both of you confirm the info in the membership list?

I've created the @jupyterhub/security team with Security Manager permissions, what remains is to add members.

closes #720
closes #716

@minrk minrk mentioned this pull request May 11, 2024
4 tasks
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minrk

Copy link

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that I would like to have my account added to the security manager role. The messaging proposed here looks good to me.

@willingc willingc requested a review from rpwagner May 13, 2024 20:52
@willingc
Copy link
Contributor

After @rpwagner reviews, let's go ahead and merge this PR. Thanks all.

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for writing this up, it's helpful to see it documented like this.

Copy link

@rpwagner rpwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming my access, thanks for documenting this process. It will help as more subprojects add this role.

@minrk
Copy link
Member Author

minrk commented May 15, 2024

Thanks all! I've added @rpwagner and @dlqqq to the security team with Security Manager permissions

@minrk minrk merged commit 5c9d564 into jupyterhub:main May 15, 2024
1 check passed
@minrk minrk deleted the doc-security-role branch May 15, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add @dlqqq to security team Add Security team
8 participants