[wip] ensure optionally-decoded characters (@, ~) are treated the same as their encoded counterparts #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heir counterparts we already had it working one direction (%40->@), but not the other (@->%40)
minrk
changed the title
minrk
changed the title
|
marking WIP since there seems to be something wonky |
|
Is there something blocking this? I have an issue with While my issue is with using |
|
Please see the discussion on jupyterhub/jupyterhub#3167. This is tricky to get right. |
MTTrackNotion77
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we already had it working one direction (%40->@), but not the other (@->%40)
related to jupyterhub/jupyterhub#1717 but not actually necessary for the fix