Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing markdown-it-mathjax npm package #39

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alfonsoalongi
Copy link

No description provided.

@alfonsoalongi
Copy link
Author

Please add these fixes and undo and redo features

@dLamSlo8
Copy link
Collaborator

Thank you for the contribution. We are currently testing it out and will get back to you as soon as possible.

@dLamSlo8
Copy link
Collaborator

Upon reviewing this pull request, we've come to several conclusions and would like your opinion on them before we consider merging in the changes.

While we understand that undo and redo features are essential to the editor, we are unsure if they belong as buttons on the toolbar, as there is already a substantial amount of buttons existing there. We suggest adding undo and redo using just the appropriate keyboard shortcuts (Cmd/Ctrl + Z/Y). Eventually, these shortcuts will be exposed in a context menu so that users know they exist.

As for the list indentation, we feel that the same reasoning applies where there is already an excess of buttons. Also, we were wondering if your intentions were just for list indentation as opposed to indentation in all aspects of the editor? We would like to hear more about your reasoning behind this before we make final changes.

We appreciate your contribution thus far and want to continue with this discussion to nail down exactly what is wanted by the community. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants