Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #618

Merged
merged 2 commits into from Mar 14, 2024
Merged

Minor fixes #618

merged 2 commits into from Mar 14, 2024

Conversation

IsabelParedes
Copy link
Member

@IsabelParedes IsabelParedes commented Mar 13, 2024 •
edited

Fixes these warnings:

warning: conversion from 'size_t' {aka 'long unsigned int'} to 'int' may change value [-Wconversion]
  120 |         backtrace_symbols_fd(array, size, STDERR_FILENO);
warning: 'void zmq::detail::socket_base::setsockopt(int, const void*, size_t)' is deprecated: from 4.7.0, use `set` taking option from zmq::sockopt [-Wdeprecated-declarations]

@IsabelParedes
Prevent double conversion
729f673 
The size would be converted from int to size_t and then back to int
when calling the function backtrace_symbols_fd().
@IsabelParedes
Remove deprecated setsockop
9d9249f
@IsabelParedes IsabelParedes marked this pull request as ready for review March 13, 2024 17:54
martinRenou
martinRenou approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit f9f8a05 into jupyter-xeus:main Mar 14, 2024
13 checks passed
@IsabelParedes IsabelParedes deleted the fixes branch March 14, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IsabelParedes @martinRenou