added emsdk and build script #600
Conversation
| # check if we are in a local build via | ||
| # export XEUS_PYTHON_LOCAL_BUILD=1 | ||
| # export XEUS_PYTHON_BUID_DIR=$XEUS_PYTHON_BUILD_DIR | ||
| XEUS_PYTHON_LOCAL_BUILD=False | ||
| if os.environ.get("XEUS_PYTHON_LOCAL_BUILD") == "1": | ||
| XEUS_PYTHON_LOCAL_BUILD=True | ||
| XEUS_PYTHON_BUILD_DIR=os.environ.get("XEUS_PYTHON_BUILD_DIR") | ||
| if XEUS_PYTHON_BUILD_DIR is None: | ||
| raise RuntimeError("XEUS_PYTHON_BUILD_DIR is not set") | ||
| XEUS_PYTHON_BUILD_DIR=Path(XEUS_PYTHON_BUILD_DIR) |
There was a problem hiding this comment.
Could we make the build directory as part of the Python package data (local dir installed alongside the Python package under site-packages)?
lite/build.sh
Outdated
| export XEUS_PYTHON_LOCAL_BUILD=1 | ||
| export XEUS_PYTHON_BUILD_DIR=$XEUS_PYTHON_BUILD_DIR | ||
| echo "building python package" | ||
| python -m pip install -e ".[dev]" |
There was a problem hiding this comment.
pip install . already calls build.py, how about putting the content of you build.sh in build.py? That way building a wheel with python -m build would do everything required to build xeus-python WASM as well.
inital build script change wasm workflow trigger use new mamba action local build works localy =) local build works localy =) cleanup build with custom pkgs works via build.py make it verbose fixit ignore lite try to adapt build workflow adding cmake fixing env disable check links atm remove build dir after build changed path changed path changed path fix tests added ui tests
|
@DerThorsten the "Enforce PR label" is for making sure each PR has a GitHub label, so the releaser changelog is automatically nicely formatted. For example for this PR you could add "enhancement" (I don't have the rights to do it on this repo) |
|
"Check Release" is to make sure the repo is always in a state where it can be released. Maybe it can be ignored for now as it's not cleared how versioning and releasing should be done now that this repo hosts multiple packages (as discussed a bit in #596) |
|
I would say we stop this effort and focus only on the plan described in jupyter-xeus/xeus-lite#7 |
No description provided.