Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestIntArray.test_bad_values #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix TestIntArray.test_bad_values #38

wants to merge 2 commits into from

Conversation

Jamim
Copy link
Contributor

@Jamim Jamim commented Jun 23, 2019

Hi there,

I'm not quite sure that it's a correct way to fix test_bad_values, but it works well with both numpy~=1.15.0 and nympy~=1.16.0.

@Jamim Jamim mentioned this pull request Jun 23, 2019
Merged
@Jamim @vidartf
Update traittypes/tests/test_traittypes.py
ecdb210 
Co-Authored-By: Vidar Tonaas Fauske <vidartf@gmail.com>
@SylvainCorlay
Copy link
Member

No idea why this would be fixing anything :/

@bnavigator
Copy link

duplicate of #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidartf vidartf vidartf left review comments

@SylvainCorlay SylvainCorlay SylvainCorlay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jamim @SylvainCorlay @bnavigator @vidartf