Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that reconnectsparkmagic cause 'Error Starting Kernel' in jupyterlab #690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qwertwwwe
Copy link

Description

Fix the bug that reconnectsparkmagic cause 'Error Starting Kernel' in jupyterlab, add the parameter 'name' in create new session.
The function self._get_kernel_manager_new_session create a new session without passing the 'name' parameter, it creates a session with its name is null, the response for api '/api/sessions' in jupyter notebook contains an item with the name is null, this cause the jupyterlab failed to load the session list. When we refresh the jupyterlab web page, jupyterlab pop a 'Error Starting Kernel' error.
Test in jupyterlab 2.1.3, this pop the error 'Error Starting Kernel'. In jupyterlab 2.2.9, it doesn't pop this error, but failed to load the running sessions in 'Running Terminals and Kernels' subpage.

Checklist

  • Wrote a description of my changes above
  • Added a bullet point for my changes to the top of the CHANGELOG.md file
  • Added or modified unit tests to reflect my changes
  • Manually tested with a notebook
  • If adding a feature, there is an example notebook and/or documentation in the README.md file

… jupyterlab, add the parameter 'name' in create new session.
@devstein
Copy link
Collaborator

devstein commented Jun 5, 2021

Hi @qwertwwwe thanks for making a PR! Can you provide instructions for reproducing the bug without this fix in Jupyterlab?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants