Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #726

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve tests #726

wants to merge 2 commits into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jan 15, 2018

Removes EnsureLoaded, which caused a local failure with fzf being installed system-wide.

@blueyed blueyed changed the title [WIP] Improve tests Improve tests Jan 15, 2018
@blueyed
Copy link
Contributor Author

blueyed commented Feb 28, 2018

@junegunn
Please consider merging the first commit at least to fix the tests.

@junegunn
Copy link
Owner

junegunn commented Mar 1, 2018

Oh, I was waiting for your response to #724 (comment) as I wanted to make sure that the changed is needed.

@blueyed
Copy link
Contributor Author

blueyed commented Mar 1, 2018

Yeah, I've remembered something - have forgotten that there was a separate PR already.

This should not be necessary in general, and causes e.g. :FZF to be
loaded from the global Vim runtime (causing an assertion failure in the
tests).

It is replaced by a verbatim / trimmed down `:runtime` for the "Check
installed plugins" test.
@blueyed
Copy link
Contributor Author

blueyed commented Nov 18, 2018

Rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants