Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow command modifiers for on-demand-loading commands #1110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

subnut
Copy link
Contributor

@subnut subnut commented Jul 18, 2021

Before this commit, commands like this -

:tab Git diff HEAD^ HEAD

were interpreted like this -

:Git diff HEAD^ HEAD

This commit fixes that issue.

Before this commit, commands like this -
	:tab Git diff HEAD^ HEAD
were interpreted like this -
	:Git diff HEAD^ HEAD
This commit fixes that issue.
09443439666 referenced this pull request Jul 24, 2021
mmm
@tomtomjhj
Copy link
Contributor

I think this needs a version guard because <mods> is a relatively new feature (v7.4.1898)

@subnut
Copy link
Contributor Author

subnut commented Nov 27, 2021

@tomtomjhj 2016 is relatively new? For whom?
I'm not trying to be sarcastic... I am genuinely interested in knowing use-cases where people need to use vim versions as old as 2016.


TBH, I'd completely forgotten about this PR 😅

@tomtomjhj
Copy link
Contributor

Of course, I believe 2016 feature is old enough to use without version check in 2021.
The only reason I think 2016 feature is relatively new is that vim-plug has checks for even older stuff, e.g.

  • vim 7.3.442, 2012
    execute 'doautocmd' ((v:version > 703 || has('patch442')) ? '<nomodeline>' : '') join(a:000)
  • git 2.0 2014 2f4e281

@janlazo
Copy link
Collaborator

janlazo commented Dec 2, 2021

I'm one of those people with old Vim versions so add a version,feature checks until @junegunn changes his mind on the minimum Vim/Neovim versions.

@subnut
Copy link
Contributor Author

subnut commented Dec 3, 2021

@janlazo Will do (please wait a few days, I am currently AFK).

I am curious about why you are still using such an old version of vim.
Can you please explain? 😅

@junegunn
Copy link
Owner

junegunn commented Dec 4, 2021

One of the strong selling points of vim-plug is its excellent backward compatibility. Most of its features work as expected even with Vim 7.0 which means that it works virtually everywhere. There can be various reasons you can't or won't use the latest versions of Vim (company guidelines, security requirements, systems with tiny resources, etc.), and still, you don't have to worry about vim-plug not working. That's a great thing and we're not going to lose that.

@janlazo
Copy link
Collaborator

janlazo commented Dec 5, 2021

@subnut Old company servers. Difficult to install or upgrade dev packages, even if it's just a newer version of Vim. Some of my colleagues don't know or care that vi,vim,$EDITOR is any version of vim. I doubt anybody there is aware of :terminal command. Some OS packages of vim disable some features are missing a few patches that I need to reliably use the new features (ie. :packadd).

@subnut
Copy link
Contributor Author

subnut commented Dec 11, 2021

Tried implementing the version guard in 82ffd4f
Please check if the implementation is correct

@subnut
Copy link
Contributor Author

subnut commented Mar 19, 2022

@janlazo @junegunn What is blocking this PR from being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants