Fix unresolved promises #3138
Draft
Fix unresolved promises #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfitzseb
reviewed
Oct 26, 2022
| @@ -64,12 +64,24 @@ export function inferJuliaNumThreads(): string { | |||
| * Same as `vscode.commands.registerCommand`, but with added middleware. | |||
| * Currently sends any uncaught errors in the command to crash reporting. | |||
| */ | |||
| export function registerCommand(cmd: string, f) { | |||
| const fWrapped = (...args) => { | |||
| export function registerAsyncCommand<T1 extends unknown[],T2>(cmd: string, f: (...arg: T1) => Promise<T2>) { | |||
There was a problem hiding this comment.
Thoughts on only using one function here which explicitly async-ifies everything?
There was a problem hiding this comment.
I also added an eslint rule that errors if a function is async when it isn't necessary. I guess we could remove that rule, but on the other hand it does seem good to not introduce unnecessary async functions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a gazillion unresolved promises in the codebase where we essentially didn't have the necessary
awaitin the code. I now enabled some eslint rules to identify those situations, and then fixed them.We can probably expect a bunch of new crash reports from this, previously we called a lot of functions in a fire-and-forget mode where any exception just disappears into the nothing :)
TODO
thenandcatch.