Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Upgrade React to 16.0.0. #3263

Merged
merged 1 commit into from Oct 5, 2017
Merged

Upgrade React to 16.0.0. #3263

merged 1 commit into from Oct 5, 2017

Conversation

huwshimi
Copy link
Member

@huwshimi huwshimi commented Oct 3, 2017

Fixes: #1709.

@huwshimi huwshimi added this to the naive nog milestone Oct 3, 2017
@huwshimi
Copy link
Member Author

huwshimi commented Oct 3, 2017

QA:

  • clean-all and rebuild
  • poke around in the GUI, there should be no errors or warnings

@jujugui
Copy link
Contributor

jujugui commented Oct 3, 2017

Refer to this link for build results (access rights to CI server needed):
http://ci-gce.jujugui.org:8080//job/juju-gui/8173/

Lukewh
Lukewh approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huwshimi

@Lukewh
Copy link
Contributor

Lukewh commented Oct 4, 2017

QA BAD

Errors when click around in the inspector regarding 'two children with the same key'. Things still work, but I believe it's a new error.

@Lukewh Lukewh added the QA: Bad label Oct 4, 2017
@huwshimi
Copy link
Member Author

huwshimi commented Oct 5, 2017

@Lukewh I wasn't able to get those errors. Do you happen to remember exactly what you did to get them?

@Lukewh
Copy link
Contributor

Lukewh commented Oct 5, 2017

@huwshimi false alarm, cleaning building and refreshing again seemed to work.

@Lukewh Lukewh added QA: OK and removed QA: Bad labels Oct 5, 2017
@hatched
Copy link
Contributor

hatched commented Oct 5, 2017

:shipit:

@jujugui
Copy link
Contributor

jujugui commented Oct 5, 2017

Status: merge request accepted. Url: http://ci-gce.jujugui.org:8080/job/juju-gui-merge

@jujugui jujugui merged commit 650516a into juju:develop Oct 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Lukewh Lukewh Lukewh approved these changes

Assignees
No one assigned
Labels
enhancement QA: OK
Milestone
naive nog - 2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@huwshimi @jujugui @Lukewh @hatched