Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This application is vulnerable to CVE-2022-24434. This means, each api endpoint which handles image uploads can be used to shut down the nodejs-server.
This issues comes in through the package
multer
, which uses another package calleddicer
, in which the vulnerability was found. The newest version of multer (1.4.5-lts.1
) now includes a fix for this vulnerability (see expressjs/multer#1097).Exploit example
As a demo, we use the
/rest/memories
endpoint to send the invalid payloadThe result of this is the nodejs-server crashing.
Resolved or fixed issue: none
Affirmation