Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to use nonexistent libpng optimizations #1339

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Commits on Jan 27, 2024

  1. Don't try to use nonexistent libpng optimizations

    The embedded copy of libpng doesn't contain code for processor-specific
    hardware optimizations, but it may still try to use them in some cases,
    resulting in linker errors.
    
    juce_PNGLoader.cpp already sets `PNG_ARM_NEON_OPT` to 0 to disable
    optimizations on ARM, but this should be done for all architectures,
    especially PowerPC, where builds currently fail.
    
    On x86, this isn't strictly necessary, because libpng optimizations are
    opt-in for x86, rather than opt-out as with all other architectures, but
    for completeness and robustness it is also included here.
    
    The macros to disable optimizations on other platforms come straight
    from libpng's own build files; this is how it disables optimizations
    when compiled without support for them. `PNG_ARM_NEON_OPT` is already
    one of those macros; this commit simply adds the other three.
    taylordotfish committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    e18a62f View commit details
    Browse the repository at this point in the history