Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

DELETE bucket without params fixed #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DELETE bucket without params fixed #152

wants to merge 1 commit into from

Conversation

vikram-chaitanya
Copy link

Hi,

When a bucket is deleted with method DELETE and no params fake-s3 throws unsupported operation error. Its fixed so when bucket name is part of the url and http method is DELETE we should delete the bucket.

Can you please review and accept this pull request? If you think there are more cases that needs to be handled let me know.

Regards,
Vikram

DELETE bucket without params fixed
@souvikduttachoudhury
Copy link

s3client.deleteBucket(bucketName) throwing exception
org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 49; White spaces are required between publicId and systemId.
Anyone has a fix to this plase suggest me

@pickhardt
Copy link
Collaborator

Hi @vikramcp,

Thanks for the pull request!

I have two comments:

  1. The parentheses around (elems.size == 1) seem extraneous and could be removed. Not a big deal if you leave it in though.

  2. We have a contributor license agreement (CLA) based off of Google and Apache's CLA. If you would feel comfortable contributing to, say, Angular.js, you should feel comfortable with this CLA.

Go here to sign the CLA: https://docs.google.com/forms/d/e/1FAIpQLSeKKSKNNz5ji1fd5bbu5RaGFbhD45zEaCnAjzBZPpzOaXQsvQ/viewform

If you're interested, this blog post discusses why to use a CLA, and even goes over the text of the CLA we based ours on.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants