Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic registration endpoint #318

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

jblemee
Copy link

@jblemee jblemee commented Apr 4, 2019

Hello,

I've re done the work done by wayward710

JB

@juanifioren
Copy link
Owner

Nice work @jblemee ! we need tests for it. Ex, Registering valid and invalid data.

@jblemee
Copy link
Author

jblemee commented Apr 24, 2019

I've added some tests, 91% coverage, hope it's enough

@jblemee
Copy link
Author

jblemee commented Apr 26, 2019

Please wait before merging I missed something important

@jblemee
Copy link
Author

jblemee commented Apr 26, 2019

Done, I let you review the new commit

@sylvainlb
Copy link

Hello there! I'm interested in this also, would it be possible to include it in a new release?

@balessan
Copy link

Interested too. Any idea when it could be available ?

@matthieu-fesselier
Copy link

Same here, very interested by this!

@juanifioren
Copy link
Owner

I'm working on documentation for this + resolving conflicts... should be ready for next version

@alexdutton
Copy link

I'm playing with this as I'm eager to use it. So far

  • The setting to enable it has a name ending _ENABLED, when similar settings end _ENABLE
  • The URL for RegisterView should probably end /?$ to match the others (i.e. the / is optional)
  • curl http://localhost:8000/register/ -XPOST (i.e. no body), causes a 500, when it should probably return a 415 Unsupported Media Type if there isn't a Content-Type: application/json request header, and 400 Bad Request if the request body isn't JSON-parseable.
  • curl http://localhost:8000/register/ -XPOST -d'{}' puts the error details in the WWW-Authenticate header, when the spec says they should be in a JSON response body
  • It'd be great if we could customise client creation, particularly as it's now possible to have a swappable client model
  • Is the openid scope the right one to control whether a client can register a new client?
  • redirect_uris is returned as a string, instead of an array
  • client_secret_expires_at is returned as a string ("0") instead of an integer
  • There's no validation of the interplay between application_type and redirect_uris (see https://openid.net/specs/openid-connect-registration-1_0.html#ClientMetadata)

Let me know if I can help to get this in, including addressing the above!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants