Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #1860

Merged
merged 7 commits into from May 19, 2024
Merged

Fix typos #1860

merged 7 commits into from May 19, 2024

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Apr 8, 2024

Fix all typos found with https://github.com/crate-ci/typos, later we can add this to the CI to prevent further introduction of typos.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Copy link
Collaborator

@ohdearaugustin ohdearaugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and shouldn't change any code logic.

@ohdearaugustin
Copy link
Collaborator

Please run prettier on docs/web-ui.md

@ohdearaugustin ohdearaugustin self-assigned this Apr 11, 2024
@majst01
Copy link
Contributor Author

majst01 commented Apr 12, 2024

Please run prettier on docs/web-ui.md

done

@ohdearaugustin
Copy link
Collaborator

There have been a lot of changes can you please rebase the PR.

@majst01
Copy link
Contributor Author

majst01 commented Apr 21, 2024

There have been a lot of changes can you please rebase the PR.

Done

@ohdearaugustin
Copy link
Collaborator

There are still some conflicts.

Copy link
Collaborator

@ohdearaugustin ohdearaugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete your secrets from the kustomize

docs/examples/kustomize/base/secrets/private-key Outdated Show resolved Hide resolved
docs/examples/kustomize/base/site/public.env Outdated Show resolved Hide resolved
docs/examples/kustomize/postgres/secrets/password Outdated Show resolved Hide resolved
@kradalby
Copy link
Collaborator

I think we should just remove the whole kustomize stuff, I can open a pr for it tomorrow

@kradalby
Copy link
Collaborator

@ohdearaugustin opened for removing kustomize #1906

@majst01
Copy link
Contributor Author

majst01 commented Apr 23, 2024

Should be in a sane state finally :-)

@majst01
Copy link
Contributor Author

majst01 commented May 1, 2024

synced with main again

@ohdearaugustin
Copy link
Collaborator

The unstable tailscale client is failing for the IntegrationTest (TestAuthKeyLogoutAndRelogin) this was not caused by this PR, but rather by an update of the client. @kradalby I hope it is okay to merge it.

@ohdearaugustin ohdearaugustin merged commit 8185a70 into juanfont:main May 19, 2024
101 of 103 checks passed
@kradalby
Copy link
Collaborator

Yes it's been in the works for a bit, great getting it in

@majst01
Copy link
Contributor Author

majst01 commented May 20, 2024

Thanks

@majst01 majst01 deleted the fix-typos branch May 20, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants