Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google workspace OIDC group support #1858

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SLoeuillet
Copy link

@SLoeuillet SLoeuillet commented Apr 6, 2024

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

@kradalby
Copy link
Collaborator

kradalby commented Apr 9, 2024

Hi

This is a new feature and per our contribution guidelines, we need to first have an issue with a discussion if this is something that we can support and what the usecase is for this feature.

I noticed that there are not integration tests, which would also be a requirement.

@SLoeuillet
Copy link
Author

Sorry, I went to the Discord server 2 weeks ago and ask if someone would be interrested in the feature and someone told me to open a PR.

Just created issue #1861

@vsychov
Copy link
Contributor

vsychov commented May 2, 2024

Do we really need it here? We could potentially utilize something like DEX to fetch groups from Google Workspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants