Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep the update channel from being cleaned up #1801

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: keep the update channel from being cleaned up #1801

wants to merge 2 commits into from

Conversation

eNdiD
Copy link

@eNdiD eNdiD commented Feb 29, 2024

  • add counter in Notifier for every machineKey
  • do not remove channel if counter is more than 1
  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #1798

fix: keep the update channel from being cleaned up
9cf963a 
- add counter in Notifier for every machineKey
- do not remove channel if counter is more than 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanfont juanfont Awaiting requested review from juanfont juanfont is a code owner

@kradalby kradalby Awaiting requested review from kradalby kradalby is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Headscale removes node after it was re-added
1 participant
@eNdiD