Add test for Sort.getOrder and Sort.create #1124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Apr 19, 2023
benmccann
reviewed
Apr 19, 2023
| @Test | ||
| public void testGetOrderAndCreate0() throws Exception { | ||
| assertThrows(IllegalStateException.class, () -> { | ||
| Table table = Table.create("table1", IntColumn.create(" ales")); |
There was a problem hiding this comment.
do you mean for there to be a space in " ales"? if so, why?
benmccann
reviewed
Apr 19, 2023
| @@ -149,4 +151,20 @@ public void createSortInvalidPrefixColumnDoesNotExist() { | |||
|
|
|||
| assertEquals("Unrecognized Column: '>col2'", thrown.getMessage()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testGetOrderAndCreate0() throws Exception { | |||
There was a problem hiding this comment.
this test name should be more descriptive. what behavior is being tested? i.e. why do you expect an IllegalStateException to be thrown?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing.
Description
Hey 馃槉
I want to contribute a test.
Curious to hear what you think!
(I wrote this test as part of a research study at TU Delft. Find out more)
Testing
Did you add a unit test?
Yes 馃槈