Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] no-danger: allow custom components as option for no-danger #3748

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented May 6, 2024

Closes #3434

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (014ee05) to head (fdd934d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3748      +/-   ##
==========================================
+ Coverage   94.45%   97.76%   +3.30%     
==========================================
  Files         134      134              
  Lines        9613     9618       +5     
  Branches     3486     3488       +2     
==========================================
+ Hits         9080     9403     +323     
+ Misses        533      215     -318     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/rules/no-danger.md Outdated Show resolved Hide resolved
lib/rules/no-danger.js Outdated Show resolved Hide resolved
lib/rules/no-danger.js Outdated Show resolved Hide resolved
lib/rules/no-danger.js Outdated Show resolved Hide resolved
tests/lib/rules/no-danger.js Show resolved Hide resolved
@akulsr0
Copy link
Contributor Author

akulsr0 commented May 16, 2024

Let me know if anything is pending here else can we proceed towards merging it?

@ljharb
Copy link
Member

ljharb commented May 24, 2024

it's good to land; i want to cut a patch release before landing new semver-minor things, is all :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

feat: no-danger find props on all components (not just native)
2 participants