New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] no-danger: allow custom components as option for no-danger #3748
Open
akulsr0
wants to merge
7
commits into
jsx-eslint:master
Choose a base branch
from
akulsr0:akul/no-danger-allow-custom-components
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Feat] no-danger: allow custom components as option for no-danger #3748
akulsr0
wants to merge
7
commits into
jsx-eslint:master
from
akulsr0:akul/no-danger-allow-custom-components
+122
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3748 +/- ##
==========================================
+ Coverage 94.45% 97.76% +3.30%
==========================================
Files 134 134
Lines 9613 9618 +5
Branches 3486 3488 +2
==========================================
+ Hits 9080 9403 +323
+ Misses 533 215 -318 ☔ View full report in Codecov by Sentry. |
ljharb
reviewed
May 6, 2024
ljharb
reviewed
May 7, 2024
ljharb
reviewed
May 7, 2024
ljharb
approved these changes
May 7, 2024
Let me know if anything is pending here else can we proceed towards merging it? |
it's good to land; i want to cut a patch release before landing new semver-minor things, is all :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3434