Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix summary being treated as non-interactive #985

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented May 6, 2024

Fixes: #656

This ensures that summary is treated as an interactive element so it doesn't raise a false positive with the no-noninteractive-element-interactions lint rule.

@khiga8
Copy link
Contributor Author

khiga8 commented May 6, 2024

I am going to test bumping axobject-query to the latest 4.0.0 since that might resolve this bug.

If bumping this package should be done with more care/breaks things, then I may instead suggest a hard-coded update to src/util/isInteractiveElement.js to immediately resolve this bug.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (0d5321a) to head (17aa88b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files         105      105           
  Lines        1636     1638    +2     
  Branches      579      581    +2     
=======================================
+ Hits         1620     1622    +2     
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khiga8 khiga8 marked this pull request as ready for review May 6, 2024 18:22
@khiga8 khiga8 requested a review from ljharb May 7, 2024 11:41
@ljharb ljharb requested a review from jessebeach May 8, 2024 14:35
@aarfing
Copy link

aarfing commented May 22, 2024

Good job. Was hoping a fix was one the way for this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

summary should be interactive
3 participants