Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transloco): 馃悰 fixed generated scope name in subdirectories #738

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JordanW9232
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 559

What is the new behavior?

Using a file in a nested directory such as "i18n/nested-scopes/admin-page/en.json" will generate the scope name as "nestedScope.adminPage" rather than "nestedScopeAdminPage".

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

stackblitz bot commented Jan 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@shaharkazaz
Copy link
Collaborator

@JordanW9232 Please refer to my comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants