fix xlsx with formulas stored with ' string delimiters, like `'Raw …

…Data'!$B$2` which were producing invalid js code when preparing handlebars calls

packages/jsreport-xlsx/lib/generation/preprocess/loop.js

@@ -677,10 +677,10 @@ module.exports = (files) => {
         continue
       }
 
-      formulaEl.textContent = `{{xlsxSData type='formula' originalCellRef='${cellRef}' originalFormula='${formula}'`
+      formulaEl.textContent = `{{xlsxSData type='formula' originalCellRef='${cellRef}' originalFormula='${jsStringEscape(formula)}'`
 
       if (sharedFormula?.type === 'source') {
-        formulaEl.setAttribute('ref', `{{xlsxSData type='formulaSharedRefRange' originalSharedRefRange='${sharedFormula.sourceRef}'}}`)
+        formulaEl.setAttribute('ref', `{{xlsxSData type='formulaSharedRefRange' originalSharedRefRange='${jsStringEscape(sharedFormula.sourceRef)}'}}`)
       }
 
       formulaEl.textContent += '}}'
@@ -1289,3 +1289,26 @@ function processClosingTag (doc, refElement, closeCall) {
   refElement.parentNode.insertBefore(fakeElement, refElement.nextSibling)
   return fakeElement
 }
+
+function jsStringEscape (string) {
+  return ('' + string).replace(/["'\\\n\r\u2028\u2029]/g, function (character) {
+    // Escape all characters not included in SingleStringCharacters and
+    // DoubleStringCharacters on
+    // http://www.ecma-international.org/ecma-262/5.1/#sec-7.8.4
+    switch (character) {
+      case '"':
+      case "'":
+      case '\\':
+        return '\\' + character
+        // Four possible LineTerminator characters need to be escaped:
+      case '\n':
+        return '\\n'
+      case '\r':
+        return '\\r'
+      case '\u2028':
+        return '\\u2028'
+      case '\u2029':
+        return '\\u2029'
+    }
+  })
+}

packages/jsreport-xlsx/test/generation/baseTest.js

@@ -519,4 +519,27 @@ describe('xlsx generation - base', () => {
     should(sheet.A4.v).be.eql(40)
     should(sheet.B4.f).be.eql('A4+B!A5')
   })
+
+  it('existing formulas that reference cells from other sheets with name stored with \' string delimiters should be handled', async () => {
+    const result = await reporter.render({
+      template: {
+        engine: 'handlebars',
+        recipe: 'xlsx',
+        xlsx: {
+          templateAsset: {
+            content: fs.readFileSync(
+              path.join(xlsxDirPath, 'existing-formula-cross-sheet-reference-with-name-string-delimiter.xlsx')
+            )
+          }
+        }
+      },
+      data: {}
+    })
+
+    fs.writeFileSync(outputPath, result.content)
+    const workbook = xlsx.read(result.content)
+    const sheet = workbook.Sheets[workbook.SheetNames[0]]
+    should(sheet.B2.f).be.eql("'Raw Data'!$B$2")
+    should(sheet.A9.f).be.eql('RawData!$A$15')
+  })
 })