fix: add bin field to npm compat tarballs
#284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojpawlik
reviewed
Mar 16, 2024
Comment on lines
+457
to
+458
| Unlike npm, JSR does not have a special field in the `jsr.json` / `deno.json` to | ||
| specify bin entrypoints. Instead, include the bin entrypoints in the `exports` |
There was a problem hiding this comment.
That might make it difficult to publish existing packages to JSR, unless https://github.com/nodejs/modules/issues/274
There was a problem hiding this comment.
Why do you say so? Your bin entrypoint does not have to be in the root entrypoint.
There was a problem hiding this comment.
I'm not exactly thrilled about having to resort to hacks, or rethink my package.json to match JSR.
There was a problem hiding this comment.
I'd be fine with this if JSR transpiled import.meta.main to something Node can understand.
wojpawlik
reviewed
Mar 24, 2024
Comment on lines
+479
to
+481
| `bin` field is added to the `package.json` in the generated npm compatible | ||
| tarball. JSR will put all files specified in the `exports` in this field that | ||
| contain a [shebang](https://en.wikipedia.org/wiki/Shebang_(Unix)#Examples). JSR |
There was a problem hiding this comment.
Docs should specify what shebang should universal code use. I believe it should be a Node shebang, since Deno will ignore it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157
Still need to add tests.